Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support PSAMask op for Ascend device #2487

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[Feature] Support PSAMask op for Ascend device #2487

merged 1 commit into from
Jan 6, 2023

Conversation

DaGaiBa
Copy link
Contributor

@DaGaiBa DaGaiBa commented Dec 14, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida
Copy link
Collaborator

Please update unit tests for this OP.

@DaGaiBa DaGaiBa requested review from grimoire and removed request for ckirchhoff2021 January 5, 2023 03:08
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida changed the title Add npu adapter for PSAMask operator. [Feature] Support PSAMask for Ascend device Jan 6, 2023
@zhouzaida zhouzaida changed the title [Feature] Support PSAMask for Ascend device [Feature] Support PSAMask op for Ascend device Jan 6, 2023
@zhouzaida zhouzaida merged commit 7385634 into open-mmlab:master Jan 6, 2023
@DaGaiBa DaGaiBa deleted the psa branch January 9, 2023 01:37
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
@OpenMMLab-Assistant001
Copy link

Hi @DaGaiBa

First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants