Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix a dilation bug of MLU-DCNv2 and add limitation of torchvision #2519

Merged
merged 1 commit into from
Jan 12, 2023
Merged

[Fix] Fix a dilation bug of MLU-DCNv2 and add limitation of torchvision #2519

merged 1 commit into from
Jan 12, 2023

Conversation

mengpenghui
Copy link

Motivation

fix a dilation bug of MLU-DCNv2 and add limitation of torchvision

Modification

mmcv/ops/modulated_deform_conv.py

  1. add assert about version of torchvision
  2. add dilation on nn.conv2d

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mengpenghui mengpenghui force-pushed the MLU_DCNv2_modify branch 3 times, most recently from 1598cac to 6411abc Compare January 5, 2023 02:14
@zhouzaida zhouzaida added the MLU label Jan 5, 2023
grimoire
grimoire approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grimoire
grimoire approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida changed the title [Fix] fix a dilation bug of MLU-DCNv2 and add limitation of torchvision [Fix] Fix a dilation bug of MLU-DCNv2 and add limitation of torchvision Jan 12, 2023
@zhouzaida zhouzaida merged commit c9d477b into open-mmlab:master Jan 12, 2023
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
@mengpenghui
[Fix] Fix a dilation bug of MLU-DCNv2 and add limitation of torchvisi…
0d17531 
…on (open-mmlab#2519)
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
@mengpenghui @CokeDong
[Fix] Fix a dilation bug of MLU-DCNv2 and add limitation of torchvisi…
7d94ba4 
…on (open-mmlab#2519)
fwenguang pushed a commit to fwenguang/mmcv that referenced this pull request Dec 19, 2023
@mengpenghui @ClowDragon
[Fix] Fix a dilation bug of MLU-DCNv2 and add limitation of torchvisi…
50f04fa 
…on (open-mmlab#2519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@grimoire grimoire grimoire approved these changes

Assignees

@ice-tong ice-tong

Labels
MLU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mengpenghui @grimoire @zhouzaida @ice-tong