Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the parameter error of DeformableRoiPool in Ascend device #2546

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

dflhw
Copy link
Contributor

@dflhw dflhw commented Jan 12, 2023

Motivation

[bug fix]Modify npu op DeformableRoiPoolGrad's parameters

Modification

swap input0 and output0

@zhouzaida zhouzaida added the NPU Ascend label Jan 13, 2023
Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zhouzaida zhouzaida changed the title Modify npu op DeformableRoiPoolGrad's parameters [Fix] Fix the parameter error of DeformableRoiPool in Ascend device Jan 19, 2023
@zhouzaida zhouzaida merged commit 0b005c5 into open-mmlab:master Jan 19, 2023
@OpenMMLab-Assistant001
Copy link

Hi @dflhw !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants