Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Check the version of torchvision in __init__ of DCN #2556

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

mengpenghui
Copy link

Motivation

When performing the MLU-based PyTorch1.6 test, because PyTorch1.6-mlu does not support DCN,
the local test case will report an error.

Modification

mmcv/ops/deform_conv.py:
-Put the assert of torchvision version in the function
-Simplified weight syntax
mmcv/ops/modulated_deform_conv.py:
-Put the assert of torchvision version in the function

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

mmcv/ops/deform_conv.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida added the MLU label Jan 17, 2023
@zhouzaida zhouzaida changed the title [Fix]Change the position of assert torchvision [Fix] Check the version torchvision in __init__ of DCN Jan 17, 2023
@zhouzaida zhouzaida changed the title [Fix] Check the version torchvision in __init__ of DCN [Fix] Check the version of torchvision in __init__ of DCN Jan 17, 2023
@zhouzaida zhouzaida merged commit e0323b4 into open-mmlab:master Jan 17, 2023
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
fwenguang pushed a commit to fwenguang/mmcv that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants