Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Ascend support for RoIAlign op #2638

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

momo609
Copy link
Collaborator

@momo609 momo609 commented Mar 3, 2023

Motivation

add roi_align op.

Modification

add roi_align op.

Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test.

Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zhouzaida zhouzaida requested a review from grimoire March 20, 2023 06:58
@zhouzaida zhouzaida changed the title add roi_align op [Feature] Add Ascend support for RoIAlign op Mar 20, 2023
@momo609 momo609 force-pushed the roialign branch 4 times, most recently from 180e4db to 637db8f Compare March 20, 2023 11:05
@zhouzaida zhouzaida merged commit 01a0f53 into open-mmlab:master Mar 20, 2023
CokeDong pushed a commit to CokeDong/mmcv that referenced this pull request Apr 24, 2023
* add roi_algin op

* add unit test

* update ops.md

* fix typo

---------

Co-authored-by: momo609 <963372609.qq.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants