-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Ascend support for RoIAlign op #2638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momo609
force-pushed
the
roialign
branch
3 times, most recently
from
March 13, 2023 10:53
dce0695
to
5126aa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit test.
ckirchhoff2021
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
zhouzaida
changed the title
add roi_align op
[Feature] Add Ascend support for RoIAlign op
Mar 20, 2023
grimoire
reviewed
Mar 20, 2023
momo609
force-pushed
the
roialign
branch
4 times, most recently
from
March 20, 2023 11:05
180e4db
to
637db8f
Compare
zhouzaida
reviewed
Mar 20, 2023
CokeDong
pushed a commit
to CokeDong/mmcv
that referenced
this pull request
Apr 24, 2023
* add roi_algin op * add unit test * update ops.md * fix typo --------- Co-authored-by: momo609 <963372609.qq.com> Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
add roi_align op.
Modification
add roi_align op.