-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Enhance the compatibility of training stylegan 2 #2694
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2694 +/- ##
==========================================
- Coverage 65.41% 65.39% -0.03%
==========================================
Files 128 128
Lines 8533 8538 +5
Branches 1218 1221 +3
==========================================
+ Hits 5582 5583 +1
- Misses 2742 2746 +4
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
* [Fix] Enhance the compatibility of training stylegan 2 * Fix unit test in PyTorch 2.0 * Apply suggestions from code review --------- Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
PyTorch consolidated convolution backward API in PR. It means users cannot train styegan2 with PyTorch version higher than 1.10.1
This PR enhances the compatibility of the code referring to the discussion
Resolve #3
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: