Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mmengine version requirement #2816

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

wateryzephyr
Copy link
Contributor

This commit addresses the bug described in:
#2815

Motivation

Fix an incorrect version constraint on mmengine.

Modification

Adjust the version constraint to one that is correct.

BC-breaking (Optional)

N/A

Use cases (Optional)

N/A

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, thanks for your contribution. Please sign the CLA before we merge this PR.

@wateryzephyr
Copy link
Contributor Author

@zhouzaida I believe I have signed the CLA but the plugin is not reflecting that.

image

I have clicked the recheck link several times already.

@OpenMMLab-Assistant-004

Hi @wateryzephyr,

We'd like to express our appreciation for your valuable contributions to the mmcv. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@wateryzephyr
Copy link
Contributor Author

@zhouzaida Please advise on how to proceed.

@zhouzaida
Copy link
Collaborator

Hi, it may be that the email address of the commit does not match your github profile. You can try to add it to your profile.

This commit addresses the bug described in:
open-mmlab#281
@wateryzephyr
Copy link
Contributor Author

@zhouzaida good catch, I had signed in on a different account. It looks like the bot has edited their answer to now say that the CLA has been signed.

@zhouzaida zhouzaida changed the title [Requirements] Correct mmengine version requirement Correct mmengine version requirement Jun 14, 2023
@zhouzaida zhouzaida linked an issue Jun 14, 2023 that may be closed by this pull request
2 tasks
@zhouzaida zhouzaida merged commit e322848 into open-mmlab:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The requirement on mmengine is incorrect
4 participants