Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix arf op's write conflict when num_orientations is not 1 #2824

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

dflhw
Copy link
Contributor

@dflhw dflhw commented Jun 8, 2023

Motivation

  1. When num_orientations is not 1, the calculation result of active_rotated_filter op on cpu is inconsistent with that on cuda.
  2. Issue link: 2718,the modified code can pass the sample test.
  3. This change does not affect scenarios where num_orientations is 1.

Modification

Indexes are added to prevent data from being written to only the first feature map.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida linked an issue Jun 9, 2023 that may be closed by this pull request
2 tasks
@zhouzaida zhouzaida changed the title [Fix] Fix arf op's write conflict when num_orientations is not 1 (main) [Fix] Fix arf op's write conflict when num_orientations is not 1 Jun 9, 2023
@zhouzaida zhouzaida merged commit c9627e8 into open-mmlab:main Jun 9, 2023
dflhw added a commit to dflhw/mmcv that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] active_rotated_filter op get a wrong value on cuda
2 participants