Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add the support of BoxIouRotated op for ascend device #2842

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[Feature] Add the support of BoxIouRotated op for ascend device #2842

merged 1 commit into from
Jul 19, 2023

Conversation

MrShadowY
Copy link
Contributor

@MrShadowY MrShadowY commented Jun 20, 2023 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add the support of BoxIouRotated op for ascend device

Modification

Add the support of BoxIouRotated op for ascend device

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.
    Tests
    image
    image
    image
    image

@zhouzaida zhouzaida added the NPU Ascend label Jun 20, 2023
@OpenMMLab-Assistant-004
Copy link

Hi @MrShadowY,

We'd like to express our appreciation for your valuable contributions to the mmcv. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@MrShadowY MrShadowY force-pushed the 0619 branch 6 times, most recently from f4772e3 to d74a48c Compare July 6, 2023 04:04
@ckirchhoff2021 ckirchhoff2021 self-requested a review July 17, 2023 08:28
ckirchhoff2021
ckirchhoff2021 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@MrShadowY MrShadowY force-pushed the 0619 branch 2 times, most recently from d5c37fa to d066139 Compare July 18, 2023 09:42
zhouzaida
zhouzaida reviewed Jul 18, 2023
View reviewed changes
tests/test_ops/test_box_iou_rotated.py Outdated
@@ -76,14 +80,27 @@ def test_box_iou_rotated(self, device):
boxes2 = torch.from_numpy(np_boxes2).to(device)

# test cw angle definition
# gpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# gpu

zhouzaida
zhouzaida reviewed Jul 18, 2023
View reviewed changes
tests/test_ops/test_box_iou_rotated.py Outdated
Comment on lines 91 to 101
# npu
boxes1_npu = torch.from_numpy(np_boxes1).npu()
boxes2_npu = torch.from_numpy(np_boxes2).npu()

ious = box_iou_rotated(boxes1_npu, boxes2_npu)
assert np.allclose(ious.cpu().numpy(), np_expect_ious, atol=1e-4)

ious = box_iou_rotated(boxes1_npu, boxes2_npu, aligned=True)
assert np.allclose(
ious.cpu().numpy(), np_expect_ious_aligned, atol=1e-4)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# npu
boxes1_npu = torch.from_numpy(np_boxes1).npu()
boxes2_npu = torch.from_numpy(np_boxes2).npu()
ious = box_iou_rotated(boxes1_npu, boxes2_npu)
assert np.allclose(ious.cpu().numpy(), np_expect_ious, atol=1e-4)
ious = box_iou_rotated(boxes1_npu, boxes2_npu, aligned=True)
assert np.allclose(
ious.cpu().numpy(), np_expect_ious_aligned, atol=1e-4)

zhouzaida
zhouzaida reviewed Jul 18, 2023
View reviewed changes
tests/test_ops/test_box_iou_rotated.py Outdated
# test ccw angle definition
# gpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# gpu

@zhouzaida zhouzaida merged commit 987d34b into open-mmlab:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@ckirchhoff2021 ckirchhoff2021 ckirchhoff2021 approved these changes

Assignees
No one assigned
Labels
NPU Ascend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrShadowY @OpenMMLab-Assistant-004 @ckirchhoff2021 @zhouzaida