import_modules_from_strings when loading cfg from file #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamerlin
force-pushed
the
custom_imports
branch
from
69cbdfd
to
083c5cc
Compare
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 64.65% 64.61% -0.05%
==========================================
Files 134 134
Lines 7645 7672 +27
Branches 1350 1358 +8
==========================================
+ Hits 4943 4957 +14
- Misses 2450 2459 +9
- Partials 252 256 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hellock
reviewed
Oct 9, 2020
|
ping @dreamerlin |
|
This is different from what I have thought. |
Unittest has been improved |
hellock
reviewed
Oct 15, 2020
hellock
approved these changes
Oct 15, 2020
wxzs5
pushed a commit
to wxzs5/mmcv
that referenced
this pull request
Nov 20, 2020
* import_modules_from_strings when loading cfg from file * add unittest to tell whether the feature is enabled as expected * minor * set an environment variable instead of writing a file * use 'shutil' instead of 'os.system'
This was referenced Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal by @innerlee in open-mmlab/mmaction2#212