Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow register multi-name for a module simultaneously #775

Merged
merged 5 commits into from
Jan 7, 2021

Conversation

nbei
Copy link
Contributor

@nbei nbei commented Jan 5, 2021

No description provided.

@nbei nbei requested a review from ZwwWayne January 5, 2021 05:37
mmcv/utils/registry.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne requested a review from hellock January 5, 2021 05:47
mmcv/utils/registry.py Outdated Show resolved Hide resolved
@hellock
Copy link
Member

hellock commented Jan 5, 2021

Unit tests failed.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #775 (dc211c0) into master (643009e) will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   62.65%   63.23%   +0.58%     
==========================================
  Files         139      143       +4     
  Lines        8271     8403     +132     
  Branches     1486     1504      +18     
==========================================
+ Hits         5182     5314     +132     
  Misses       2820     2820              
  Partials      269      269              
Flag Coverage Δ
unittests 63.23% <100.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/registry.py 97.36% <100.00%> (+0.14%) ⬆️
mmcv/tensorrt/init_plugins.py 0.00% <0.00%> (ø)
mmcv/tensorrt/__init__.py 0.00% <0.00%> (ø)
mmcv/onnx/info.py 12.50% <0.00%> (ø)
mmcv/tensorrt/tensorrt_utils.py 0.00% <0.00%> (ø)
mmcv/ops/roi_align.py 60.00% <0.00%> (+5.34%) ⬆️
mmcv/onnx/simplify/common.py 13.79% <0.00%> (+13.79%) ⬆️
mmcv/onnx/simplify/core.py 14.04% <0.00%> (+14.04%) ⬆️
mmcv/onnx/onnx_utils/symbolic_helper.py 19.87% <0.00%> (+19.87%) ⬆️
mmcv/onnx/symbolic.py 25.38% <0.00%> (+25.38%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643009e...dc211c0. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 276883f into open-mmlab:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants