Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of DCN #819

Merged
merged 2 commits into from
Feb 7, 2021
Merged

fix bug of DCN #819

merged 2 commits into from
Feb 7, 2021

Conversation

jshilong
Copy link
Collaborator

@jshilong jshilong commented Feb 4, 2021

resolve: #818

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #819 (77f869a) into master (6c57b88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #819   +/-   ##
=======================================
  Coverage   62.23%   62.23%           
=======================================
  Files         144      144           
  Lines        8506     8506           
  Branches     1522     1522           
=======================================
  Hits         5294     5294           
  Misses       2945     2945           
  Partials      267      267           
Flag Coverage Δ
unittests 62.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c57b88...77f869a. Read the comment docs.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Feb 4, 2021

Please benchmark the model of DCN to ensure correctness.

@jshilong
Copy link
Collaborator Author

jshilong commented Feb 7, 2021

Please benchmark the model of DCN to ensure correctness.

I benchmark the faster_rcnn_r50_fpn_dconv_c3-c5_1x_coco.py and get 41.4, there should be no problem

@ZwwWayne ZwwWayne merged commit 4712db7 into open-mmlab:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report a bug of DCN when batch_size / cur_im2col_step > 1
2 participants