Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add register_itertimer_hook function #838

Merged
merged 7 commits into from
Feb 20, 2021
Merged

Conversation

MeowZheng
Copy link
Collaborator

Fixes #837

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #838 (17a48c2) into master (f75a88c) will decrease coverage by 0.04%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
- Coverage   62.93%   62.89%   -0.05%     
==========================================
  Files         145      145              
  Lines        8677     8686       +9     
  Branches     1569     1571       +2     
==========================================
+ Hits         5461     5463       +2     
- Misses       2951     2958       +7     
  Partials      265      265              
Flag Coverage Δ
unittests 62.89% <27.27%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/base_runner.py 66.51% <27.27%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75a88c...ea45607. Read the comment docs.

mmcv/runner/base_runner.py Outdated Show resolved Hide resolved
mmcv/runner/base_runner.py Outdated Show resolved Hide resolved
mmcv/runner/base_runner.py Outdated Show resolved Hide resolved
mmcv/runner/base_runner.py Outdated Show resolved Hide resolved
@hellock hellock merged commit 7fa78e7 into open-mmlab:master Feb 20, 2021
@MeowZheng MeowZheng deleted the fix_runner branch February 20, 2021 03:01
@xiaosai666
Copy link

xiaosai666 commented Feb 20, 2021

File "/root/***/env1/mmcv/mmcv/runner/base_runner.py", line 423, in register_timer_hook
hook = mmcv.buid_from_cfg(timer_config_, HOOKS)
There's a small bug in line 423

@MeowZheng
Copy link
Collaborator Author

we have fixed it in pr #840 , and will merge it in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change IterTimerHook registration strategy in base_runner.py
3 participants