[Feature] Support auto contrast #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 66.49% 66.59% +0.09%
==========================================
Files 145 145
Lines 8790 8816 +26
Branches 1600 1602 +2
==========================================
+ Hits 5845 5871 +26
Misses 2629 2629
Partials 316 316
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
12 tasks
ZwwWayne
reviewed
Mar 9, 2021
|
LGTM, can be merged after resolving comments. |
ZwwWayne
approved these changes
Mar 9, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this pull request,
auto_contrastis added for data augmentation. Pls kindly take a look. Thx.One thing to note is that in the implementation, the cut-off value can be a tuple as (low, high). However, setting low/high cut-offs differently is only supported by pillow above version 8.0.0, and in
build.ymlversion 6.2.2 is installed. Therefore I explained it in the unittest and did not cover this part in the unittest. However I have tested them locally to ensure the implementation is correct and has the exact output as pillow 8.0.1 does.