Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update weight initialization in cnn.md #912

Merged
merged 15 commits into from
May 13, 2021

Conversation

zhouzaida
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #912 (aac4aab) into master (9b8dd08) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #912   +/-   ##
=======================================
  Coverage   65.01%   65.01%           
=======================================
  Files         154      154           
  Lines        9893     9893           
  Branches     1801     1801           
=======================================
  Hits         6432     6432           
  Misses       3127     3127           
  Partials      334      334           
Flag Coverage Δ
unittests 65.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/utils/weight_init.py 91.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8dd08...aac4aab. Read the comment docs.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base on weight initialization design , users must give values for layer or override.

docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we give some explanations for sequential or modulelist? ref:#884

@zhouzaida
Copy link
Collaborator Author

should we give some explanations for sequential or modulelist? ref:#884

yep, but maybe we should firstly add doc for sequential or modulelist.

docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
@zhouzaida
Copy link
Collaborator Author

ping @MeowZheng

@MeowZheng
Copy link
Collaborator

init_weight has been renamed to init_weights ref #971

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your nice work. It looks good to me.

@zhouzaida zhouzaida requested a review from ZwwWayne April 23, 2021 10:06
docs/cnn.md Show resolved Hide resolved
@zhouzaida zhouzaida mentioned this pull request May 6, 2021
13 tasks
docs/cnn.md Outdated Show resolved Hide resolved
docs/cnn.md Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit a1d3bf1 into open-mmlab:master May 13, 2021
@zhouzaida zhouzaida deleted the weight_init_doc branch May 23, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants