Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onnx-simplify source code(deprecated) #927

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Remove onnx-simplify source code(deprecated) #927

merged 2 commits into from
Apr 9, 2021

Conversation

QingChuanWS
Copy link
Contributor

@QingChuanWS QingChuanWS commented Apr 7, 2021

  1. The purpose of this PR: The onnx-simplify 3rd party package already supports importing custom operator.
  2. For the repo that is still using the onnx simplify function in mmcv.onnx, firstly you need to install the onnx-simplify 3rd party package with the version greater than 0.3.0, then remove the mmcv.onnx.simplify and implement the onnx simplify according to the simplify() in onnxsim.
  3. This PR is associated with mmdetection #4913, and mmcv.onnx.simplify is used in mmdetection to complete the simplify of the onnx model.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #927 (93971c2) into master (83cf25b) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 93971c2 differs from pull request most recent head 0e43b15. Consider uploading reports for the commit 0e43b15 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   64.62%   64.71%   +0.08%     
==========================================
  Files         148      145       -3     
  Lines        9354     9088     -266     
  Branches     1698     1626      -72     
==========================================
- Hits         6045     5881     -164     
+ Misses       2962     2889      -73     
+ Partials      347      318      -29     
Flag Coverage Δ
unittests 64.71% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/bricks/conv.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cf25b...0e43b15. Read the comment docs.

@RunningLeon RunningLeon self-requested a review April 7, 2021 05:09
@RunningLeon RunningLeon changed the title Remove the simplify model Remove onnx-simplify source code(deprecated) Apr 7, 2021
@RunningLeon
Copy link
Collaborator

RunningLeon commented Apr 7, 2021

This PR focus on remove the custom simplify model in mmcv.

@QingChuanWS
Please update the description of this PR:

  1. clarify why we have to remove this feature
  2. what impact it would have

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit b5e1fac into open-mmlab:master Apr 9, 2021
@QingChuanWS QingChuanWS deleted the simplify branch April 9, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants