-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove onnx-simplify source code(deprecated) #927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 64.62% 64.71% +0.08%
==========================================
Files 148 145 -3
Lines 9354 9088 -266
Branches 1698 1626 -72
==========================================
- Hits 6045 5881 -164
+ Misses 2962 2889 -73
+ Partials 347 318 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@QingChuanWS
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mmcv.onnx
, firstly you need to install the onnx-simplify 3rd party package with the version greater than 0.3.0, then remove themmcv.onnx.simplify
and implement the onnx simplify according to thesimplify()
in onnxsim.mmcv.onnx.simplify
is used in mmdetection to complete the simplify of the onnx model.