Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Revise override in init_cfg #930

Merged
merged 6 commits into from
Apr 12, 2021
Merged

Conversation

MeowZheng
Copy link
Collaborator

deep copy override_ to improve the robustness

@MeowZheng MeowZheng changed the title [Fix] Config deep copy in initialize_override [WIP] Revise override config Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #930 (9f58cc4) into master (83cf25b) will increase coverage by 0.05%.
The diff coverage is 64.59%.

❗ Current head 9f58cc4 differs from pull request most recent head bfa764e. Consider uploading reports for the commit bfa764e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   64.62%   64.68%   +0.05%     
==========================================
  Files         148      151       +3     
  Lines        9354     9604     +250     
  Branches     1698     1760      +62     
==========================================
+ Hits         6045     6212     +167     
- Misses       2962     3036      +74     
- Partials      347      356       +9     
Flag Coverage Δ
unittests 64.68% <64.59%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/bricks/conv.py 100.00% <ø> (ø)
mmcv/engine/test.py 26.88% <26.88%> (ø)
mmcv/cnn/utils/weight_init.py 89.72% <60.00%> (-1.94%) ⬇️
mmcv/runner/hooks/evaluation.py 87.24% <87.24%> (ø)
mmcv/engine/__init__.py 100.00% <100.00%> (ø)
mmcv/onnx/onnx_utils/symbolic_helper.py 33.72% <100.00%> (ø)
mmcv/runner/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/hooks/__init__.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de39b1...bfa764e. Read the comment docs.

@MeowZheng MeowZheng changed the title [WIP] Revise override config [Fix] Revise override config Apr 12, 2021
@MeowZheng MeowZheng changed the title [Fix] Revise override config [Fix] Revise override in init_cfg Apr 12, 2021
@MeowZheng MeowZheng requested a review from ZwwWayne April 12, 2021 04:32
@@ -362,3 +401,21 @@ def test_initialize():
dict(type='Constant', name='conv2d_3', val=5, bias=6)
])
initialize(foonet, init_cfg)

# test override with args except type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except type?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except type key

@ZwwWayne ZwwWayne merged commit 2fadb1a into open-mmlab:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants