-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rotated ROI align op for pytorch (cpu&cuda), parrots (cpu&cuda) and onnxruntime (cpu) #933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 65.49% 65.74% +0.25%
==========================================
Files 148 150 +2
Lines 9373 9518 +145
Branches 1704 1725 +21
==========================================
+ Hits 6139 6258 +119
- Misses 2915 2937 +22
- Partials 319 323 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please fix the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parrots support is ready now.
|
||
#include "../ort_mmcv_utils.h" | ||
|
||
// Implementation taken from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put it to the top of the file to be consistent with those inmmcv/ops/csrc/parrots/roi_align_rotated_cpu.cpp
@@ -0,0 +1,199 @@ | |||
#ifndef ROI_ALIGN_ROTATED_CUDA_KERNEL_CUH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting steps.