Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rotated ROI align op for pytorch (cpu&cuda), parrots (cpu&cuda) and onnxruntime (cpu) #933

Merged
merged 15 commits into from
Apr 19, 2021

Conversation

Johnson-Wang
Copy link
Collaborator

@Johnson-Wang Johnson-Wang commented Apr 10, 2021

Awaiting steps.

  • Add unittest for RoIAlignRotated

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #933 (bedc0df) into master (b5e1fac) will increase coverage by 0.25%.
The diff coverage is 83.78%.

❗ Current head bedc0df differs from pull request most recent head d228af5. Consider uploading reports for the commit d228af5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
+ Coverage   65.49%   65.74%   +0.25%     
==========================================
  Files         148      150       +2     
  Lines        9373     9518     +145     
  Branches     1704     1725      +21     
==========================================
+ Hits         6139     6258     +119     
- Misses       2915     2937      +22     
- Partials      319      323       +4     
Flag Coverage Δ
unittests 65.74% <83.78%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/box_iou_rotated.py 100.00% <ø> (ø)
mmcv/ops/deform_conv.py 61.76% <31.25%> (-4.36%) ⬇️
mmcv/runner/hooks/lr_updater.py 65.78% <75.00%> (+1.39%) ⬆️
mmcv/ops/roi_align_rotated.py 75.38% <75.38%> (ø)
mmcv/cnn/__init__.py 100.00% <100.00%> (ø)
mmcv/cnn/builder.py 100.00% <100.00%> (ø)
mmcv/cnn/utils/weight_init.py 91.89% <100.00%> (+0.22%) ⬆️
mmcv/ops/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/base_module.py 79.41% <100.00%> (ø)
mmcv/utils/registry.py 98.33% <100.00%> (+0.86%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e1fac...d228af5. Read the comment docs.

@Johnson-Wang Johnson-Wang removed the WIP label Apr 11, 2021
@ZwwWayne
Copy link
Collaborator

Please fix the CLA.

Copy link
Contributor

@luopeichao luopeichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parrots support is ready now.

@Johnson-Wang Johnson-Wang changed the title Add Rotated ROI align op for pytorch, parrots and onnxruntime Add Rotated ROI align op for pytorch (cpu&cuda), parrots (cpu&cuda) and onnxruntime (cpu) Apr 12, 2021

#include "../ort_mmcv_utils.h"

// Implementation taken from
Copy link
Collaborator

@ZwwWayne ZwwWayne Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it to the top of the file to be consistent with those inmmcv/ops/csrc/parrots/roi_align_rotated_cpu.cpp

@@ -0,0 +1,199 @@
#ifndef ROI_ALIGN_ROTATED_CUDA_KERNEL_CUH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZwwWayne ZwwWayne merged commit ee041ce into open-mmlab:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants