Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init cfg #958

Merged
merged 1 commit into from
Apr 18, 2021
Merged

fix init cfg #958

merged 1 commit into from
Apr 18, 2021

Conversation

jshilong
Copy link
Collaborator

@jshilong jshilong commented Apr 16, 2021

Motivation

I think the existence of attributes in an instance should not depend on the value of the arguments. So I change the all hasattr(self, 'init_cfg') to self.init_cfg in BaseModule.

BC-breaking

None

@jshilong
Copy link
Collaborator Author

Please @hhaAndroid @ZwwWayne check whether it affects the existing changes in the downstream codebase.

@jshilong jshilong requested a review from MeowZheng April 16, 2021 14:50
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #958 (7854c59) into master (ae41150) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 7854c59 differs from pull request most recent head 92c3c59. Consider uploading reports for the commit 92c3c59 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   65.64%   65.64%   -0.01%     
==========================================
  Files         149      149              
  Lines        9455     9454       -1     
  Branches     1722     1721       -1     
==========================================
- Hits         6207     6206       -1     
  Misses       2928     2928              
  Partials      320      320              
Flag Coverage Δ
unittests 65.64% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/base_module.py 78.78% <66.66%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae41150...92c3c59. Read the comment docs.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit de4f14e into open-mmlab:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants