Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect citation in transformer documentation. #974

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

whughw
Copy link
Contributor

@whughw whughw commented Apr 21, 2021

The original citation of the paper On Layer Normalization in the Transformer Architecture https://arxiv.org/abs/2007.08103 is wrong.
It should be https://arxiv.org/abs/2002.04745

The original citation of the paper On Layer Normalization in the Transformer Architecture <https://arxiv.org/abs/2007.08103> is wrong.
It should be <https://arxiv.org/abs/2002.04745>
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #974 (3c7daed) into master (a764163) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   65.73%   65.73%           
=======================================
  Files         150      150           
  Lines        9517     9517           
  Branches     1726     1726           
=======================================
  Hits         6256     6256           
  Misses       2938     2938           
  Partials      323      323           
Flag Coverage Δ
unittests 65.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/bricks/transformer.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a764163...3c7daed. Read the comment docs.

@zhouzaida zhouzaida requested a review from jshilong April 22, 2021 02:59
@jshilong
Copy link
Collaborator

Thanks for your correction.

@ZwwWayne ZwwWayne merged commit 9649a9a into open-mmlab:master Apr 23, 2021
@OpenMMLab-Assistant-007
Copy link

Hi!
@whughw
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants