Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support centernet dev1.x #1219

Merged

Conversation

hanrui1sensetime
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support CenterNet which is P0 model.
But trt 8.4.x has bugs in dynamic shape configs. Refer to: NVIDIA/TensorRT#2299

Modification

  • Rewriter
  • UT and reg tests
  • docs

BC-breaking (Optional)

None.

Use cases (Optional)

None.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hanrui1sensetime hanrui1sensetime changed the base branch from master to dev-1.x October 18, 2022 11:58
@RunningLeon
Copy link
Collaborator

@hanrui1sensetime pls. fix lint error.

@hanrui1sensetime hanrui1sensetime force-pushed the support_centernet_dev1.x branch from 5b3101e to 2f20161 Compare October 19, 2022 02:32
@RunningLeon
Copy link
Collaborator

@hanrui1sensetime may fix conflicts.

@grimoire
Copy link
Member

The result is different between tensorrt and pytorch

@grimoire
Copy link
Member

And we better find a way to get rid of adding new config. @RunningLeon

@hanrui1sensetime
Copy link
Collaborator Author

The result is different between tensorrt and pytorch
May be caused by TensorRT issue 2299 NVIDIA/TensorRT#2299
Do you test different between tensorrt and pytorch on TRT-8.2.x too?

@RunningLeon
Copy link
Collaborator

@lzhangzz sdk ci failed, is there something wrong with changes of Pad?

@RunningLeon
Copy link
Collaborator

@hanrui1sensetime pls fix conflicts of docs

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls. correct the docs.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon
Copy link
Collaborator

@grimoire @lvhan028 Hi, guys, any other comment on this PR?

@RunningLeon RunningLeon merged commit 83756b9 into open-mmlab:dev-1.x Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants