[Fix] Fix aligned allocations on Android #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
reviewed
Jan 6, 2023
irexyc
pushed a commit
to irexyc/mmdeploy
that referenced
this pull request
Jan 11, 2023
* fix android alignment * fix typo * fix size
irexyc
pushed a commit
to irexyc/mmdeploy
that referenced
this pull request
Jan 11, 2023
* fix android alignment * fix typo * fix size
irexyc
pushed a commit
to irexyc/mmdeploy
that referenced
this pull request
Jan 16, 2023
* fix android alignment * fix typo * fix size
lzhangzz
added a commit
that referenced
this pull request
Jan 17, 2023
…1.x (#1635) * [Fix] Fix example standalone build for msvc (#1626) * fix example build for msvc * move /Zc:__cplusplus to core * [FIX] Fix csharp net48 and batch inference (#1370) * fix csharp net48 * add missing file * update * fix batch inference * update demo * update * update version * update nuget package version & fix project name * build monolithic SDK by default (#1577) * Fix debug build for PoseTracker (#1601) * [Fix] Fix aligned allocations on Android (#1612) * fix android alignment * fix typo * fix size * Fix build error on windows-cuda platform (#1598) * [Fix] Relax module adapter template constraints (#1366) * relax module adapter constraint * remove forwarding `operator()` * fix YOLOV5Head naming Co-authored-by: Li Zhang <lzhang329@gmail.com>
lvhan028
pushed a commit
that referenced
this pull request
Mar 1, 2023
…1.x (#1635) * [Fix] Fix example standalone build for msvc (#1626) * fix example build for msvc * move /Zc:__cplusplus to core * [FIX] Fix csharp net48 and batch inference (#1370) * fix csharp net48 * add missing file * update * fix batch inference * update demo * update * update version * update nuget package version & fix project name * build monolithic SDK by default (#1577) * Fix debug build for PoseTracker (#1601) * [Fix] Fix aligned allocations on Android (#1612) * fix android alignment * fix typo * fix size * Fix build error on windows-cuda platform (#1598) * [Fix] Relax module adapter template constraints (#1366) * relax module adapter constraint * remove forwarding `operator()` * fix YOLOV5Head naming Co-authored-by: Li Zhang <lzhang329@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
posix_memalignon Android platform, and set minimum alignment tosizeof(void*)std::aligned_allocis not available in all versions of NDK toolchains.alignmentis too small.newandmallocare aligned tosizeof(void*)anyway.https://en.cppreference.com/w/cpp/memory/c/aligned_alloc