[Enhancement] Support cmake configure when system exists multiple cuda versions. #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
Feb 9, 2023
lvhan028
approved these changes
Feb 13, 2023
lzhangzz
approved these changes
Feb 13, 2023
irexyc
added a commit
to irexyc/mmdeploy
that referenced
this pull request
Feb 14, 2023
…a versions. (open-mmlab#1740) * update cmake * typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On windows, to support cmake use cuda as a language, one need to install cuda msbuild extensions that cuda installer provides.
When configure mmdeploy with cuda, if not specify cuda toolkit, cmake will use the highest cuda extensions found in
$(VCTargetsPath)\BuildCustomizations. And it also need environment variableCUDA_PATH_V{X}_{Y}to be set.When using
find_package(CUDA), it will first searchCUDA_PATHand then the dir ofnvcc.exeifnvcc.execan be found. The search path should be compatible with used extensions.Usage.
cmake -A x64 -T v142,cuda="/path/to/cuda" ..cmake -A x64 -T v142,cuda="/path/to/cuda" .. OR cmake -A x64 -T v142,cuda=x.y