-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] sdk normalization to_rgb option not working #1771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, @SineYuan please sign the CLA. |
Codecov ReportBase: 44.34% // Head: 44.34% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
=======================================
Coverage 44.34% 44.34%
=======================================
Files 356 356
Lines 12773 12773
Branches 1813 1813
=======================================
Hits 5664 5664
Misses 6714 6714
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4b05689
to
f95e7e9
Compare
ok, signed |
SineYuan,您好!您在MMXXX项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。 |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
fix problem on mmdeploy sdk normalization operation option
to_rgb
not working whileto_float
option set to false.Modification
csrc/mmdeploy/preprocess/transform/normalize.cpp
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist