Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: Fix mmrotate and regression script #1917

Merged
merged 2 commits into from
Mar 28, 2023
Merged

[Fix]: Fix mmrotate and regression script #1917

merged 2 commits into from
Mar 28, 2023

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Mar 24, 2023 •
edited
Loading

Motivation

Fix

Modification

  • Fix oriented_rcnn+onnxruntime visualization failure. No input_shape is set for static deploy config.
  • Fix regression_test.py
  • Disable regression test for openvino and SDK+torchscript for mmpose codebase.

BC-breaking (Optional)

None

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon marked this pull request as ready for review March 24, 2023 09:29
@lvhan028 lvhan028 requested a review from grimoire March 24, 2023 12:10
grimoire
grimoire approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon requested a review from AllentDan March 27, 2023 02:42
AllentDan
AllentDan approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 7237b91 into open-mmlab:dev-1.x Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 left review comments

@AllentDan AllentDan AllentDan approved these changes

@grimoire grimoire grimoire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RunningLeon @grimoire @lvhan028 @AllentDan