Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix errors about deploying MMYOLO-OpenVINO, DETR, ConvFormer and RTMDet #1919

Merged
merged 18 commits into from
Mar 31, 2023
Merged

[Fix] Fix errors about deploying MMYOLO-OpenVINO, DETR, ConvFormer and RTMDet #1919

merged 18 commits into from
Mar 31, 2023

Conversation

hanrui1sensetime
Copy link
Collaborator

@hanrui1sensetime hanrui1sensetime commented Mar 24, 2023 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix bugs.

Modification

  • MMYolo OpenVINO configs in regression test.
  • DETR after refactor in mmdet 3.0.0rc6 support(DetectionTransformer detector) deploy support.
  • RTMDet SDK precision loss fix.
  • ConvFormer score loss fix and SDK failed fix(sdk result is slightly different from pytorch inference because the resize using pillow and mmcv are different).
  • Related UT above.

BC-breaking (Optional)

None.

Use cases (Optional)

None.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hanrui1sensetime hanrui1sensetime changed the title [WIP] Fix reg 2023 mar [Fix] Fix regression tests 2023 March Mar 29, 2023
@lvhan028 lvhan028 requested a review from grimoire March 29, 2023 13:30
@lvhan028 lvhan028 changed the title [Fix] Fix regression tests 2023 March [Fix] Fix errors about deploying MMYOLO-OpenVINO, DETR, ConvFormer and RTMDet Mar 30, 2023
RunningLeon
RunningLeon reviewed Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression test failed with detr+trt on torch1.8.0 1.10.0 and 1.12.0

@hanrui1sensetime
Copy link
Collaborator Author

regression test failed with detr+trt on torch1.8.0 1.10.0 and 1.12.0

See NVIDIA/TensorRT#2326

RunningLeon
RunningLeon approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit d76c7b6 into open-mmlab:dev-1.x Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunningLeon RunningLeon RunningLeon approved these changes

@lvhan028 lvhan028 lvhan028 approved these changes

@grimoire grimoire grimoire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanrui1sensetime @grimoire @lvhan028 @RunningLeon