Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build_from_source.md #1994

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Update build_from_source.md #1994

merged 4 commits into from
Apr 28, 2023

Conversation

stozn
Copy link
Contributor

@stozn stozn commented Apr 15, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@stozn stozn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trim trailing whitespace

@irexyc
Copy link
Collaborator

irexyc commented Apr 17, 2023

@OpenMMLab-Assistant-004

Hi @liuzhixin2003 !We are grateful for your efforts in helping improve mmdeploy open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

@RunningLeon RunningLeon added the documentation Improvements or additions to documentation label Apr 20, 2023
@irexyc
Copy link
Collaborator

irexyc commented Apr 23, 2023

Hi @liuzhixin2003 , thanks for you contribution, can you also update the en docs and rebase the main branch ? Therefore, the lint error should be fixed.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irexyc irexyc self-requested a review April 28, 2023 06:08
@RunningLeon RunningLeon merged commit ca773a7 into open-mmlab:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants