Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support opset_version 13 #2071

Merged
merged 15 commits into from
May 17, 2023

Conversation

RunningLeon
Copy link
Collaborator

Motivation

Support torch2onnx with opset_version=13 for backends like torchscript, onnxruntime, tensorrt, openvino.

Note that for ncnn, use opset_version<=11

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

None

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon added the enhancement New feature or request label May 11, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.03 ⚠️

Comparison is base (9385eed) 49.70% compared to head (780ac72) 49.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
- Coverage   49.70%   49.68%   -0.03%     
==========================================
  Files         339      339              
  Lines       12976    12995      +19     
  Branches     1900     1905       +5     
==========================================
+ Hits         6450     6456       +6     
- Misses       6077     6088      +11     
- Partials      449      451       +2     
Flag Coverage Δ
unittests 49.68% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/apis/onnx/passes/optimize_onnx.py 14.28% <ø> (ø)
...det/models/task_modules/prior_generators/anchor.py 27.08% <0.00%> (ø)
...mdeploy/codebase/mmdet3d/deploy/voxel_detection.py 69.33% <0.00%> (-1.90%) ⬇️
mmdeploy/apis/onnx/optimizer.py 58.06% <35.29%> (-27.65%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RunningLeon RunningLeon requested review from grimoire and irexyc May 15, 2023 06:23
@RunningLeon
Copy link
Collaborator Author

@irexyc @grimoire any comment on this PR?

@RunningLeon RunningLeon merged commit 1c7749d into open-mmlab:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants