Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uploading assets #2130

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

RunningLeon
Copy link
Collaborator

Motivation

uploading assets fails due to the wrong tag_name of action softprops/action-gh-release@v1. See issue softprops/action-gh-release#360

Modification

use gh script to upload assets

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon added the CI label May 29, 2023
@RunningLeon RunningLeon requested a review from irexyc May 29, 2023 09:17
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (faf05fe) 49.73% compared to head (2892680) 49.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2130   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         339      339           
  Lines       12997    12997           
  Branches     1906     1906           
=======================================
  Hits         6464     6464           
  Misses       6080     6080           
  Partials      453      453           
Flag Coverage Δ
unittests 49.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RunningLeon RunningLeon requested a review from grimoire May 31, 2023 07:19
@RunningLeon RunningLeon merged commit a26945c into open-mmlab:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants