Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch2onnx for pointpillars with multi-level outputs #2210

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

RunningLeon
Copy link
Collaborator

Motivation

Fix #2200

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon added WIP bug Something isn't working labels Jun 25, 2023
@RunningLeon RunningLeon changed the title [WIP]: Fix torch2onnx for mmdet3d pointpillars with multi-level features Fix torch2onnx for pointpillars with multi-level outputs Jun 26, 2023
@RunningLeon RunningLeon removed the WIP label Jun 26, 2023
@RunningLeon RunningLeon requested review from tpoisonooo and irexyc June 26, 2023 11:07
@RunningLeon
Copy link
Collaborator Author

@tpoisonooo @irexyc any comment on this PR? BTW, the ci error has nothing todo with this PR and should be fixed in another PR.

@RunningLeon RunningLeon merged commit ebd6b75 into open-mmlab:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] assert self.num_levels == len(featmap_sizes)
3 participants