Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: fix rtmdet-inst sdk #2343

Merged
merged 13 commits into from
Sep 4, 2023
Merged

Conversation

RunningLeon
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage is 11.62% of modified lines.

❗ Current head d9eb6c7 differs from pull request most recent head dc873af. Consider uploading reports for the commit dc873af to get more accurate results

Files Changed Coverage
mmdeploy/codebase/mmdet/deploy/object_detection.py 0.00%
mmdeploy/mmcv/ops/nms.py 0.00%
...debase/mmdet/models/dense_heads/rtmdet_ins_head.py 3.84%
...oy/codebase/mmdet/deploy/object_detection_model.py 28.57%

📢 Thoughts on this report? Let us know!.

@RunningLeon RunningLeon requested a review from grimoire August 29, 2023 08:34
@RunningLeon
Copy link
Collaborator Author

@grimoire @irexyc hi, any comment on this PR?

@RunningLeon RunningLeon requested a review from irexyc September 4, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants