Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ONNXRuntime Compiler Error #2432

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

flytocc
Copy link
Contributor

@flytocc flytocc commented Sep 13, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

[bugfix] windows下编译onnxruntime自定义算子时出错"C3863不可指定数组类型" #2430

Modification

使用std::vector替代数组,即将float tmp[N];修改为std::vector<float> tmp(N);

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit bb031c6 into open-mmlab:main Sep 14, 2023
24 checks passed
@RunningLeon RunningLeon added Windows bug Something isn't working labels Sep 14, 2023
@flytocc flytocc deleted the fix-ort-compiler-error branch December 8, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants