Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix the onnx exportation for yoloxpose in mmpose #2466

Merged
merged 8 commits into from
Oct 23, 2023

Conversation

Ben-Louis
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

In the latest version of mmpose, YOLOX-Pose models have been moved from projects to the core package. As a result, the model structure has changed and the old implementation in mmdeploy is no longer compatible.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files Coverage Δ
mmdeploy/codebase/mmpose/deploy/pose_detection.py 72.19% <ø> (ø)
...loy/codebase/mmpose/deploy/pose_detection_model.py 53.03% <23.07%> (-1.24%) ⬇️
...oy/codebase/mmpose/models/heads/yolox_pose_head.py 18.75% <7.69%> (-0.61%) ⬇️

... and 9 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@Ben-Louis Ben-Louis force-pushed the lupeng/fix-mmpose-yoloxpose branch from 207c30f to 4b7f638 Compare October 20, 2023 10:59
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 6edd802 into open-mmlab:main Oct 23, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants