-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] fix the onnx exportation for yoloxpose in mmpose #2466
Merged
RunningLeon
merged 8 commits into
open-mmlab:main
from
Ben-Louis:lupeng/fix-mmpose-yoloxpose
Oct 23, 2023
Merged
[Fix] fix the onnx exportation for yoloxpose in mmpose #2466
RunningLeon
merged 8 commits into
open-mmlab:main
from
Ben-Louis:lupeng/fix-mmpose-yoloxpose
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 9 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
irexyc
approved these changes
Sep 28, 2023
RunningLeon
reviewed
Sep 28, 2023
RunningLeon
reviewed
Sep 28, 2023
RunningLeon
reviewed
Oct 20, 2023
Ben-Louis
force-pushed
the
lupeng/fix-mmpose-yoloxpose
branch
from
October 20, 2023 10:59
207c30f
to
4b7f638
Compare
RunningLeon
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
In the latest version of mmpose, YOLOX-Pose models have been moved from projects to the core package. As a result, the model structure has changed and the old implementation in mmdeploy is no longer compatible.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist