Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp2023-555 #2469

Merged
merged 12 commits into from
Oct 8, 2023
Merged

CodeCamp2023-555 #2469

merged 12 commits into from
Oct 8, 2023

Conversation

Boomerl
Copy link
Contributor

@Boomerl Boomerl commented Sep 28, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Boomerl Boomerl closed this Sep 28, 2023
@Boomerl Boomerl reopened this Sep 28, 2023
@RunningLeon RunningLeon self-requested a review September 28, 2023 03:50
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...ploy/codebase/mmdet/models/dense_heads/__init__.py 100.00% <100.00%> (ø)
...oy/codebase/mmdet/deploy/object_detection_model.py 38.34% <0.00%> (ø)
mmdeploy/pytorch/functions/repeat.py 41.66% <0.00%> (-8.34%) ⬇️
mmdeploy/codebase/mmdet/deploy/object_detection.py 50.00% <0.00%> (-1.21%) ⬇️
...mdet/models/detectors/single_stage_instance_seg.py 40.00% <16.66%> (-7.62%) ⬇️
...codebase/mmdet/models/dense_heads/condinst_head.py 62.16% <62.16%> (ø)

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@RunningLeon RunningLeon requested a review from irexyc October 7, 2023 07:24
@Boomerl
Copy link
Contributor Author

Boomerl commented Oct 7, 2023

10/07 17:11:54 - mmengine - INFO - Environmental information
10/07 17:11:55 - mmengine - INFO - sys.platform: linux
10/07 17:11:55 - mmengine - INFO - Python: 3.9.17 (main, Jul 5 2023, 20:41:20) [GCC 11.2.0]
10/07 17:11:55 - mmengine - INFO - CUDA available: True
10/07 17:11:55 - mmengine - INFO - numpy_random_seed: 2147483648
10/07 17:11:55 - mmengine - INFO - GPU 0,1,2,3,4,5,6,7: NVIDIA GeForce RTX 3080
10/07 17:11:55 - mmengine - INFO - CUDA_HOME: None
10/07 17:11:55 - mmengine - INFO - GCC: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
10/07 17:11:55 - mmengine - INFO - PyTorch: 1.12.1+cu116
10/07 17:11:55 - mmengine - INFO - PyTorch compiling details: PyTorch built with:

  • GCC 9.3
  • C++ Version: 201402
  • Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
  • Intel(R) MKL-DNN v2.6.0 (Git Hash 52b5f107dd9cf10910aaa19cb47f3abf9b349815)
  • OpenMP 201511 (a.k.a. OpenMP 4.5)
  • LAPACK is enabled (usually provided by MKL)
  • NNPACK is enabled
  • CPU capability usage: AVX2
  • CUDA Runtime 11.6
  • NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86
  • CuDNN 8.6 (built against CUDA 11.8)
    • Built with CuDNN 8.3.2
  • Magma 2.6.1
  • Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.6, CUDNN_VERSION=8.3.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -fabi-version=11 -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Werror=cast-function-type -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.12.1, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=OFF, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF,

10/07 17:11:55 - mmengine - INFO - TorchVision: 0.13.1+cu116
10/07 17:11:55 - mmengine - INFO - OpenCV: 4.8.0
10/07 17:11:55 - mmengine - INFO - MMEngine: 0.8.2
10/07 17:11:55 - mmengine - INFO - MMCV: 2.0.1
10/07 17:11:55 - mmengine - INFO - MMCV Compiler: GCC 9.3
10/07 17:11:55 - mmengine - INFO - MMCV CUDA Compiler: 11.6
10/07 17:11:55 - mmengine - INFO - MMDeploy: 1.3.0+be7042e
10/07 17:11:55 - mmengine - INFO -

10/07 17:11:55 - mmengine - INFO - Backend information
10/07 17:11:55 - mmengine - INFO - tensorrt: 8.5.1.7
10/07 17:11:55 - mmengine - INFO - tensorrt custom ops: NotAvailable
10/07 17:11:55 - mmengine - INFO - ONNXRuntime: None
10/07 17:11:55 - mmengine - INFO - ONNXRuntime-gpu: 1.10.0
10/07 17:11:55 - mmengine - INFO - ONNXRuntime custom ops: NotAvailable
10/07 17:11:55 - mmengine - INFO - pplnn: None
10/07 17:11:55 - mmengine - INFO - ncnn: None
10/07 17:11:55 - mmengine - INFO - snpe: None
10/07 17:11:55 - mmengine - INFO - openvino: None
10/07 17:11:55 - mmengine - INFO - torchscript: 1.12.1+cu116
10/07 17:11:55 - mmengine - INFO - torchscript custom ops: NotAvailable
10/07 17:11:55 - mmengine - INFO - rknn-toolkit: None
10/07 17:11:55 - mmengine - INFO - rknn-toolkit2: None
10/07 17:11:55 - mmengine - INFO - ascend: None
10/07 17:11:55 - mmengine - INFO - coreml: None
10/07 17:11:55 - mmengine - INFO - tvm: None
10/07 17:11:55 - mmengine - INFO - vacc: None
10/07 17:11:55 - mmengine - INFO -

10/07 17:11:55 - mmengine - INFO - Codebase information
10/07 17:11:55 - mmengine - INFO - mmdet: 3.0.0
10/07 17:11:55 - mmengine - INFO - mmseg: None
10/07 17:11:55 - mmengine - INFO - mmpretrain: None
10/07 17:11:55 - mmengine - INFO - mmocr: None
10/07 17:11:55 - mmengine - INFO - mmagic: None
10/07 17:11:55 - mmengine - INFO - mmdet3d: None
10/07 17:11:55 - mmengine - INFO - mmpose: None
10/07 17:11:55 - mmengine - INFO - mmrotate: None
10/07 17:11:55 - mmengine - INFO - mmaction: None
10/07 17:11:55 - mmengine - INFO - mmrazor: None

@RunningLeon
Copy link
Collaborator

@Boomerl hi, pls fix lint error by running pip install pre-commit && pre-commit run --all-files inside mmdeploy root directory.

@Boomerl Boomerl requested a review from RunningLeon October 8, 2023 02:11
@irexyc
Copy link
Collaborator

irexyc commented Oct 8, 2023

--dump-info 模型导出的信息中后处理部分不对,应该是 ResizeInstanceMask

这个地方有个bug,resize_height / resize_width 写反了,可以一块改一下。
https://github.com/open-mmlab/mmdeploy/blob/main/csrc/mmdeploy/codebase/mmdet/instance_segmentation.cpp#L152

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon merged commit 4c376d9 into open-mmlab:main Oct 8, 2023
22 checks passed
@Boomerl
Copy link
Contributor Author

Boomerl commented Oct 9, 2023

ok, i will do it soon.

@Boomerl Boomerl deleted the codecamp-555 branch November 10, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants