Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cuda resize #45

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

lzhangzz
Copy link
Collaborator

@lzhangzz lzhangzz commented Jan 5, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

#40 adds support for ppl.cv 0.6, but it breaks builds using ppl.cv < 0.6; This PR brings back support for ppl.cv prior to 0.6.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lzhangzz lzhangzz requested review from grimoire and lvhan028 January 5, 2022 09:02
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #45 (1e087c7) into master (c6fccd0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files         172      172           
  Lines        5661     5661           
  Branches      900      900           
=======================================
  Hits         3817     3817           
  Misses       1558     1558           
  Partials      286      286           
Flag Coverage Δ
unittests 67.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6fccd0...1e087c7. Read the comment docs.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 03ae26c into open-mmlab:master Jan 6, 2022
@lzhangzz lzhangzz deleted the refactor-cuda-resize branch June 13, 2022 03:52
hanrui1sensetime pushed a commit to hanrui1sensetime/mmdeploy that referenced this pull request Nov 25, 2022
* update logo (open-mmlab#37)

* [Docs] Update images with new logo (open-mmlab#38)

* Update model_design.md

Update logo

* Revert "Update model_design.md"

This reverts commit 207f5295220ba966c7d55a7ec655fdf1aab7860f.

* Update yolov5_description.md

Update logo

* Update model_design.md

Update logo

* Update model_design.md

Update logo

* Update README.md

Update logo

* Update README_zh-CN.md

Update logo

* Add GIF Link (open-mmlab#40)

* Update README.md

* Update README_zh-CN.md

* Update README.md

* Update README_zh-CN.md

* Fix typos in config.md

* Add citation of yolov6

* Add citation of yolov5

* Fix links in README.md

* Fix typos in data_flow.md in en

Co-authored-by: wanghonglie <wanghonglie@zju.edu.cn>
Co-authored-by: MingJian.L <45811724+matrixgame2018@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants