Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Remove deepcopy in patch_model #61

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

SingleZombie
Copy link
Contributor

Motivation

When patch_model, we have to deepcopy a model, which increases the memory overhead.

Modification

Remove deepcopy and add comments.

@SingleZombie SingleZombie added the enhancement New feature or request label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #61 (315c8c0) into master (d1528e5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   67.60%   67.59%   -0.01%     
==========================================
  Files         173      173              
  Lines        5713     5712       -1     
  Branches      908      908              
==========================================
- Hits         3862     3861       -1     
  Misses       1569     1569              
  Partials      282      282              
Flag Coverage Δ
unittests 67.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/core/rewriters/rewriter_manager.py 100.00% <ø> (ø)
mmdeploy/core/rewriters/module_rewriter.py 95.12% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1528e5...315c8c0. Read the comment docs.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SingleZombie SingleZombie merged commit 12ee956 into open-mmlab:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants