Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBoxHead missing conv init #218

Closed
thangvubk opened this issue Dec 30, 2018 · 3 comments
Closed

BBoxHead missing conv init #218

thangvubk opened this issue Dec 30, 2018 · 3 comments

Comments

@thangvubk
Copy link
Contributor

thangvubk commented Dec 30, 2018 •
edited
Loading

ConvFCBBoxHead has FC inits only while detectron has both FC and conv initialized.
@hellock
Copy link
Member

hellock commented Dec 30, 2018

This is indeed misleading since we explicitly initialize fc layers but ignore conv layers. We use ConvModule in ConvFCBBoxHead, and ConvModule is implicitly initialized with kaiming_init by default.

@thangvubk
Copy link
Contributor Author

Thanks for your info. I think implicit points should have a comment.

@hellock
Copy link
Member

hellock commented Dec 30, 2018

Thanks for your info. I think implicit points should have a comment.

Totally agree. It will be updated.

@ZwwWayne ZwwWayne mentioned this issue Mar 18, 2020
Merged
@hellock hellock closed this as completed Mar 18, 2020
FANGAreNotGnu pushed a commit to FANGAreNotGnu/mmdetection that referenced this issue Oct 23, 2023
@zhreshold
Fix open-mmlab#218: fix arg names and orders (open-mmlab#436)
5168b89 
* fix arg names and orders

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellock @thangvubk