Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace imshow_det_bboxes visualization backend #4389

Merged
merged 22 commits into from
Jan 13, 2021

Conversation

hhaAndroid
Copy link
Collaborator

Replace imshow_det_bboxes visualization backend

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #4389 (a358224) into master (103a4dd) will increase coverage by 0.22%.
The diff coverage is 67.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4389      +/-   ##
==========================================
+ Coverage   61.78%   62.01%   +0.22%     
==========================================
  Files         239      241       +2     
  Lines       18269    18335      +66     
  Branches     3060     3071      +11     
==========================================
+ Hits        11288    11370      +82     
+ Misses       6433     6409      -24     
- Partials      548      556       +8     
Flag Coverage Δ
unittests 61.97% <67.50%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 19.51% <0.00%> (-0.03%) ⬇️
mmdet/models/detectors/base.py 55.30% <16.66%> (+3.12%) ⬆️
mmdet/core/visualization/image.py 72.85% <72.85%> (ø)
mmdet/core/visualization/__init__.py 100.00% <100.00%> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 74.45% <0.00%> (-2.32%) ⬇️
mmdet/core/bbox/samplers/sampling_result.py 73.01% <0.00%> (-1.59%) ⬇️
mmdet/models/dense_heads/cascade_rpn_head.py 28.07% <0.00%> (-0.20%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103a4dd...a358224. Read the comment docs.

@hhaAndroid
Copy link
Collaborator Author

opencv backend (old):
image

matplotlib backend(new):
image

mmdet/apis/inference.py Outdated Show resolved Hide resolved
@hhaAndroid
Copy link
Collaborator Author

opencv backend (old):
image

matplotlib backend(new):
image

also you can specify the mask color
image

@hiyyg
Copy link
Contributor

hiyyg commented Jan 7, 2021

@hhaAndroid How about putting the text inside the bbox? Otherwise if the bbox is on the top of the image, the text might not be shown.

@hhaAndroid hhaAndroid closed this Jan 7, 2021
@ZwwWayne ZwwWayne reopened this Jan 7, 2021
@hhaAndroid
Copy link
Collaborator Author

@hiyyg
I try it
image

Doesn't seem to work very well,due to the size and the distance of the object, the y coordinate of the text is not easy to set

@hiyyg
Copy link
Contributor

hiyyg commented Jan 7, 2021

@hhaAndroid
Copy link
Collaborator Author

@hiyyg Thank you,Let me see

@hhaAndroid
Copy link
Collaborator Author

@hiyyg I found that it can be achieved by
verticalalignment="top" horizontalalignment="left"

image

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jan 9, 2021

Also involves @MeowZheng to review

@hellock
Copy link
Member

hellock commented Jan 9, 2021

Better to add a filling color for text regions.

@hhaAndroid
Copy link
Collaborator Author

Better to add a filling color for text regions.

image

@ZwwWayne ZwwWayne merged commit 308f0d7 into open-mmlab:master Jan 13, 2021
@hhaAndroid hhaAndroid deleted the vis_bbox branch March 19, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants