Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Unify the interface of stuff head and panoptic head #6308

Merged
merged 7 commits into from
Oct 20, 2021

Conversation

AronLin
Copy link
Contributor

@AronLin AronLin commented Oct 18, 2021

Replace fg_range and bg_range with num_thing_classes and num_stuff_classes.
Deprecated two interfaces fg_range and bg_range.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #6308 (023fe4c) into master (a32d7d4) will increase coverage by 0.02%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6308      +/-   ##
==========================================
+ Coverage   61.82%   61.85%   +0.02%     
==========================================
  Files         315      315              
  Lines       25166    25174       +8     
  Branches     4185     4187       +2     
==========================================
+ Hits        15560    15572      +12     
+ Misses       8797     8789       -8     
- Partials      809      813       +4     
Flag Coverage Δ
unittests 61.83% <5.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/seg_heads/panoptic_fpn_head.py 25.45% <5.88%> (-2.21%) ⬇️
...et/models/roi_heads/bbox_heads/convfc_bbox_head.py 55.88% <0.00%> (ø)
mmdet/models/dense_heads/corner_head.py 69.67% <0.00%> (+2.45%) ⬆️
mmdet/models/detectors/cornernet.py 100.00% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32d7d4...023fe4c. Read the comment docs.

@AronLin
Copy link
Contributor Author

AronLin commented Oct 18, 2021

I will train a model to ensure that the modification is correct.

@ZwwWayne ZwwWayne merged commit 9874180 into open-mmlab:master Oct 20, 2021
@AronLin AronLin deleted the interface branch November 12, 2021 06:11
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants