Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SSH Module #8953

Merged
merged 16 commits into from
Dec 15, 2022
Merged

add SSH Module #8953

merged 16 commits into from
Dec 15, 2022

Conversation

MambaWong
Copy link
Contributor

add SSH Module.

@ZwwWayne ZwwWayne added this to the 3.0.0rc2 milestone Oct 8, 2022
@ZwwWayne ZwwWayne assigned hhaAndroid and unassigned BIGWangYuDong Oct 8, 2022
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Oct 8, 2022

Hi @MambaWong ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@MambaWong
Copy link
Contributor Author

@ZwwWayne need upgrade pre commit hooks described in #8963 ？

BIGWangYuDong
BIGWangYuDong reviewed Oct 8, 2022
View reviewed changes
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
@BIGWangYuDong
Copy link
Collaborator

Maybe we can add some config demo in configs.

@MambaWong MambaWong requested review from BIGWangYuDong and removed request for hhaAndroid October 9, 2022 00:36
BIGWangYuDong
BIGWangYuDong reviewed Oct 12, 2022
View reviewed changes
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
@MambaWong MambaWong force-pushed the SSH branch 2 times, most recently from bfeab30 to 4fcfe0c Compare October 12, 2022 23:21
hhaAndroid
hhaAndroid reviewed Oct 20, 2022
View reviewed changes
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
mmdet/models/necks/ssh.py Outdated Show resolved Hide resolved
@MambaWong MambaWong requested review from hhaAndroid and removed request for BIGWangYuDong October 20, 2022 06:13
@ZwwWayne ZwwWayne modified the milestones: 3.0.0rc2, 3.0.0rc3 Oct 21, 2022
MambaWong and others added 4 commits November 15, 2022 16:37
@MambaWong
add SSH Module
8e04c71
@MambaWong @BIGWangYuDong
Update mmdet/models/necks/ssh.py
eb8522c 
Co-authored-by: BigDong <yudongwang1226@gmail.com>
@MambaWong @BIGWangYuDong
Update mmdet/models/necks/ssh.py
aa60489 
Co-authored-by: BigDong <yudongwang1226@gmail.com>
@MambaWong @BIGWangYuDong
Update mmdet/models/necks/ssh.py
b3510bd 
Co-authored-by: BigDong <yudongwang1226@gmail.com>
@MambaWong MambaWong requested a review from hhaAndroid November 15, 2022 08:38
@BIGWangYuDong
Copy link
Collaborator

LGTM now

@MambaWong MambaWong requested review from BIGWangYuDong and removed request for hhaAndroid November 28, 2022 02:29
@ZwwWayne ZwwWayne merged commit 28513d5 into open-mmlab:dev-3.x Dec 15, 2022
@MambaWong MambaWong deleted the SSH branch December 15, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhaAndroid hhaAndroid hhaAndroid approved these changes

@BIGWangYuDong BIGWangYuDong Awaiting requested review from BIGWangYuDong

Assignees

@hhaAndroid hhaAndroid

Labels
None yet
Projects
None yet
Milestone
3.0.0rc4
Development

Successfully merging this pull request may close these issues.
4 participants
@MambaWong @ZwwWayne @BIGWangYuDong @hhaAndroid