Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Prepare for merging refactor-detr #9656

Merged
merged 3 commits into from
Jan 28, 2023
Merged

[Fix] Prepare for merging refactor-detr #9656

merged 3 commits into from
Jan 28, 2023

Conversation

Li-Qingyun
Copy link
Contributor

@Li-Qingyun Li-Qingyun commented Jan 20, 2023 •
edited
Loading

We (me, @jshilong, @LYMDLUT, and @KeiChiTse) have refactored DETR-like models, to enhance the usability and readability of our codebase. This PR fix the branch refactor-detr to prepare for merging.

  • update links in readme of Mask2Former (adding the latest checkpoint of better PQ)
  • fix lacking of copyright announcement
  • fix unit test file of Mask?Former pixel decoder plugins
  • click and test the link after uploading the new model and log

@Li-Qingyun Li-Qingyun changed the base branch from master to refactor-detr January 20, 2023 16:45
@Li-Qingyun
Copy link
Contributor Author

Invite @jshilong to review ~ 3g u

@Czm369 Czm369 requested a review from jshilong January 20, 2023 22:17
@Li-Qingyun Li-Qingyun mentioned this pull request Jan 21, 2023
Merged
jshilong
jshilong reviewed Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@jshilong jshilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all copyright line added for new files?

@Li-Qingyun
Copy link
Contributor Author

Is all copyright line added for new files?

yes, I've checked

@jshilong
Copy link
Collaborator

We need to update the checkpoint after the Chinese new year holiday with the help of @hhaAndroid

@jshilong
Copy link
Collaborator

Please check if is there any else that needs to do for refactor-detr, we should add them to this pr

@Li-Qingyun
Copy link
Contributor Author

Please check if is there any else that needs to do for refactor-detr, we should add them to this pr

okkkkk

@ZwwWayne ZwwWayne requested a review from jshilong January 28, 2023 03:45
@ZwwWayne ZwwWayne merged commit 130a620 into open-mmlab:refactor-detr Jan 28, 2023
@Li-Qingyun Li-Qingyun deleted the fix-refactor-detr branch January 28, 2023 07:16
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@Li-Qingyun @yumion
[Fix] Update Mask2Former models (open-mmlab#9656)
585a20e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

@jshilong jshilong Awaiting requested review from jshilong

Assignees

@BIGWangYuDong BIGWangYuDong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Li-Qingyun @jshilong @ZwwWayne @BIGWangYuDong