Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix img_shape. #9966

Merged
merged 2 commits into from
Mar 17, 2023
Merged

[Fix] Fix img_shape. #9966

merged 2 commits into from
Mar 17, 2023

Conversation

RangiLyu
Copy link
Member

@RangiLyu RangiLyu commented Mar 16, 2023 •
edited
Loading

img_shape should be (h, w)

TODO:

  • Unit tests

@RangiLyu RangiLyu requested a review from hhaAndroid March 16, 2023 12:30
@hhaAndroid
Copy link
Collaborator

LGTM

@RangiLyu RangiLyu changed the title [WIP] Fix img_shape. [Fix] Fix img_shape. Mar 17, 2023
@RangiLyu RangiLyu added the bug Something isn't working label Mar 17, 2023
BIGWangYuDong
BIGWangYuDong approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhaAndroid
Copy link
Collaborator

@RangiLyu CI Failed

@RangiLyu
Copy link
Member Author

@RangiLyu CI Failed

TestInferenceBenchmark failed

@ZwwWayne ZwwWayne merged commit 0f5cd10 into open-mmlab:dev-3.x Mar 17, 2023
@RangiLyu RangiLyu mentioned this pull request Mar 20, 2023
Closed
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@RangiLyu @yumion
[Fix] Fix img_shape in data pipeline (open-mmlab#9966)
cb8f8a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BIGWangYuDong BIGWangYuDong BIGWangYuDong approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

@hhaAndroid hhaAndroid Awaiting requested review from hhaAndroid

Assignees

@RangiLyu RangiLyu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RangiLyu @hhaAndroid @ZwwWayne @BIGWangYuDong