Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module not registered bug #1625

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1625 (b223f7b) into dev (b1ea1a8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1625   +/-   ##
=======================================
  Coverage   50.15%   50.15%           
=======================================
  Files         223      223           
  Lines       19124    19124           
  Branches     3141     3141           
=======================================
  Hits         9591     9591           
  Misses       8953     8953           
  Partials      580      580           
Flag Coverage Δ
unittests 50.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/roi_heads/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ea1a8...b223f7b. Read the comment docs.

@ZwwWayne ZwwWayne merged commit f30aaec into open-mmlab:dev Jul 19, 2022
@Xiangxu-0103 Xiangxu-0103 deleted the fix_register_bug branch September 24, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants