Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix bbox_color in Det3DLocalVisualizer #2729

Closed
wants to merge 4 commits into from
Closed

[Fix] fix bbox_color in Det3DLocalVisualizer #2729

wants to merge 4 commits into from

Conversation

maciejmajek
Copy link

@maciejmajek maciejmajek commented Sep 12, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Examples like this are not working because of a bug.
Error trace:

TypeError: paint_uniform_color(): incompatible function arguments. The following argument types are supported:
    1. (self: open3d.cuda.pybind.geometry.LineSet, color: numpy.ndarray[numpy.float64[3, 1]]) -> open3d.cuda.pybind.geometry.LineSet

Invoked with: LineSet with 12 lines., 0.0

Modification

Add code that determines whether to use a single color for all bounding boxes or force the user to specify a color for each bbox.

BC-breaking (Optional)

Use cases (Optional)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@maciejmajek maciejmajek changed the title fix bbox_color in Det3DLocalVisualizer [Fix] fix bbox_color in Det3DLocalVisualizer Sep 12, 2023
@maciejmajek maciejmajek marked this pull request as draft September 12, 2023 16:13
@maciejmajek maciejmajek marked this pull request as ready for review September 12, 2023 16:40
@OpenMMLab-Assistant-004

Hi @Maciejeg,

We'd like to express our appreciation for your valuable contributions to the mmdetection3d. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Files Coverage Δ
mmdet3d/visualization/local_visualizer.py 25.65% <0.00%> (-0.29%) ⬇️

📢 Thoughts on this report? Let us know!.

@Xiangxu-0103 Xiangxu-0103 changed the base branch from main to dev-1.x September 13, 2023 10:31
@ZCMax
Copy link
Collaborator

ZCMax commented Sep 27, 2023

Supporting assigning color for each box can be well applied to the need that assigning the color of each box according to its category.

@maciejmajek maciejmajek closed this by deleting the head repository Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants