Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix ndarray metainfo check in ConcatDataset #1333

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

NrealLzx
Copy link
Contributor

@NrealLzx NrealLzx commented Sep 1, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Be able to check the metainfo which is one numpy ndarray. #1330

Modification

     if isinstance(self._metainfo[key], np.ndarray) and isinstance(
                        dataset.metainfo[key], np.ndarray):
                    if not np.array_equal(self._metainfo[key],
                                          dataset.metainfo[key]):
                        raise ValueError(
                            f'The meta information of the {i}-th dataset does'
                            'not match meta information of the first dataset')

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida linked an issue Sep 1, 2023 that may be closed by this pull request
zhouzaida
zhouzaida previously approved these changes Sep 1, 2023
@zhouzaida zhouzaida changed the title [Fix]: fix ndarray metainfo check in ConcatDataset [Fix] Fix ndarray metainfo check in ConcatDataset Sep 1, 2023
@zhouzaida zhouzaida added this to the 0.8.5 milestone Sep 1, 2023
@zhouzaida zhouzaida merged commit 762c9a2 into open-mmlab:main Sep 1, 2023
6 of 9 checks passed
@OpenMMLab-Assistant-004
Copy link

Hi @NrealLzx,

We'd like to express our appreciation for your valuable contributions to the mmengine. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] ConcatDataset metainfo check supports numpy array
4 participants