[Enhance] Support for installing minimal runtime dependencies #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
reviewed
Sep 21, 2023
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
zhouzaida
previously approved these changes
Oct 8, 2023
zhouzaida
previously approved these changes
Oct 8, 2023
zhouzaida
previously approved these changes
Oct 8, 2023
zhouzaida
changed the title
zhouzaida
approved these changes
Oct 8, 2023
weiji14
added a commit
to regro-cf-autotick-bot/mmengine-feedstock
that referenced
this pull request
Oct 10, 2023
Equivalent to setting `MMENGINE_LITE=1`. Xref https://github.com/open-mmlab/mmengine/blame/v0.9.0/requirements/runtime_lite.txt and open-mmlab/mmengine#1362.
weiji14
added a commit
to regro-cf-autotick-bot/mmengine-feedstock
that referenced
this pull request
Oct 11, 2023
3 tasks
weiji14
added a commit
to conda-forge/mmengine-feedstock
that referenced
this pull request
Oct 11, 2023
* updated v0.9.0 * MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and conda-forge-pinning 2023.10.10.09.57.53 * Remove matplotlib-base and opencv Equivalent to setting `MMENGINE_LITE=1`. Xref https://github.com/open-mmlab/mmengine/blame/v0.9.0/requirements/runtime_lite.txt and open-mmlab/mmengine#1362. * Add packaging as runtime dependency * Set MMENGINE_LITE=1 flag Xref open-mmlab/mmengine#1362 --------- Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support installing mmengine without matplotlib and opencv by
MMENGINE_LITE=1 pip install -e .Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist