Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support for installing minimal runtime dependencies #1362

Merged
merged 13 commits into from
Oct 8, 2023

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support installing mmengine without matplotlib and opencv by

MMENGINE_LITE=1 pip install -e .

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

.circleci/test.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

zhouzaida
zhouzaida previously approved these changes Oct 8, 2023
zhouzaida
zhouzaida previously approved these changes Oct 8, 2023
zhouzaida
zhouzaida previously approved these changes Oct 8, 2023
@zhouzaida zhouzaida changed the title [Enhance] Support install mmengine lite [Enhance] Support for installing minimal runtime dependencies Oct 8, 2023
@zhouzaida zhouzaida merged commit 95d8758 into open-mmlab:main Oct 8, 2023
17 of 20 checks passed
weiji14 added a commit to regro-cf-autotick-bot/mmengine-feedstock that referenced this pull request Oct 10, 2023
weiji14 added a commit to regro-cf-autotick-bot/mmengine-feedstock that referenced this pull request Oct 11, 2023
weiji14 added a commit to conda-forge/mmengine-feedstock that referenced this pull request Oct 11, 2023
* updated v0.9.0

* MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and conda-forge-pinning 2023.10.10.09.57.53

* Remove matplotlib-base and opencv

Equivalent to setting `MMENGINE_LITE=1`. Xref https://github.com/open-mmlab/mmengine/blame/v0.9.0/requirements/runtime_lite.txt and open-mmlab/mmengine#1362.

* Add packaging as runtime dependency

* Set MMENGINE_LITE=1 flag

Xref open-mmlab/mmengine#1362

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants