Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix placement policy in ColossalAIStrategy #1440

Merged
merged 5 commits into from
Dec 23, 2023

Conversation

fanqiNO1
Copy link
Collaborator

@fanqiNO1 fanqiNO1 commented Nov 26, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

placement_policy in ColossalAIStrategy must be auto or static when using ColossalAI==0.3.4.

https://github.com/hpcaitech/ColossalAI/blob/main/colossalai/zero/gemini/placement_policy.py#L202

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida
Copy link
Collaborator

keep the CollosalAIModelWrapper to avoid bc and also register it to MODEL_WRAPPERS

@zhouzaida zhouzaida merged commit 671f3bc into open-mmlab:main Dec 23, 2023
17 of 20 checks passed
@fanqiNO1 fanqiNO1 deleted the fix_colo branch December 23, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants