Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add vis backend for MLflow. #878

Merged
merged 54 commits into from
Apr 7, 2023

Conversation

sh0622-kim
Copy link
Contributor

@sh0622-kim sh0622-kim commented Jan 13, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

I was reading the API documentation to use MLflow. With a recent update, I found out that MLflow is not available
I read that issue #731 is looking for a developer to develop the features I want. I hope this helps.

Modification

Add vis backend for MLflow.

BC-breaking (Optional)

While adding VIS and verifying it, a NoneType error occurred in mmengine/model/base_module.py Line 170: handler.stream.write, so a conditional statement was added. Please review if there is any problem.

Use cases (Optional)

visualizer = dict(
    type='ClsVisualizer', vis_backends=[dict(type='LocalVisBackend'), dict(type='MLflowVisBackend')])

image

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2023

CLA assistant check
All committers have signed the CLA.

mmengine/visualization/vis_backend.py Show resolved Hide resolved
mmengine/visualization/vis_backend.py Outdated Show resolved Hide resolved
mmengine/visualization/vis_backend.py Outdated Show resolved Hide resolved
@HAOCHENYE
Copy link
Collaborator

BTW, we should also update docs/en/api/visualization.rst and docs/zh_cn/api/visualization.rst

mmengine/visualization/vis_backend.py Outdated Show resolved Hide resolved
mmengine/visualization/vis_backend.py Outdated Show resolved Hide resolved
sh0622-kim and others added 7 commits March 7, 2023 15:35
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@sh0622-kim
Copy link
Contributor Author

@zhouzaida

Is there any way to verify that this code works with Multi GPU training?
I have not been able to verify it due to limited resources in my development environment.

@HAOCHENYE
Copy link
Collaborator

@zhouzaida

Is there any way to verify that this code works with Multi GPU training? I have not been able to verify it due to limited resources in my development environment.

Thanks for your contribution. I've tested it in ddp training and it worked as expected. We'll merge this PR ASAP!

@zhouzaida
Copy link
Collaborator

zhouzaida commented Apr 7, 2023

@HAOCHENYE Thanks for your contribution. This PR will be merged after passing the CI.

@zhouzaida zhouzaida merged commit 8bf1eca into open-mmlab:main Apr 7, 2023
@sh0622-kim sh0622-kim deleted the feature-support-mlflow branch April 7, 2023 09:42
@OpenMMLab-Assistant001
Copy link

Hi @sh0622-kim !We are grateful for your efforts in helping improve this open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

@zimonitrome
Copy link
Contributor

Nice, now we only need the ability to log custom artifacts too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants