Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Save the memory to visualization backends #974

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Mar 1, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

add memory in other log

Modification

add memory in other log

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_str means the logs displayed in the terminal or logs dumped into xxx.log. As described in #916, we want to see memory information in the saved JSON file, Tensorboard or WandB, therefore we should add memory filed to tag, rather than extend the log_str

@enkilee
Copy link
Contributor Author

enkilee commented Mar 3, 2023

log_str means the logs displayed in the terminal or logs dumped into xxx.log. As described in #916, we want to see memory information in the saved JSON file, Tensorboard or WandB, therefore we should add memory filed to tag, rather than extend the log_str

yes,but i read the code and docs, i can't find which code to generate json or other file and format the display information.

@zhouzaida
Copy link
Collaborator

Hi, you can modify the following lines

if is_cuda_available():
log_str += f'memory: {self._get_max_memory(runner)} '

to

        if is_cuda_available():
            max_memory = self._get_max_memory(runner)
            log_str += f'memory: {max_memory}  '
            tag['memory'] = max_memory
            

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@cb7e04d). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 47e8b58 differs from pull request most recent head d2b0617. Consider uploading reports for the commit d2b0617 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #974   +/-   ##
=======================================
  Coverage        ?   76.51%           
=======================================
  Files           ?      138           
  Lines           ?    10852           
  Branches        ?     2168           
=======================================
  Hits            ?     8303           
  Misses          ?     2191           
  Partials        ?      358           
Flag Coverage Δ
unittests 76.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida changed the title add memory in other log [Enhancement] Save the memory to visualization backends Mar 8, 2023
@zhouzaida zhouzaida merged commit 4585c36 into open-mmlab:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] The memory filed is not saved in all visualization backends.
4 participants