[Feature] Support DDP Evaluation for IS and FID #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbei
reviewed
Nov 1, 2021
|
|
||
| def parse_args(): | ||
| parser = argparse.ArgumentParser(description='Evaluate a GAN model') | ||
| parser = argparse.ArgumentParser(description='Evaluate a Generation model') |
There was a problem hiding this comment.
We may also need to change the related docs to inform this feature.
There was a problem hiding this comment.
quick_run.md is updated.
| rank, _ = get_dist_info() | ||
| rank, world_size = get_dist_info() | ||
| cfg.gpu_ids = range(world_size) | ||
| assert args.online or world_size == 1, ( |
There was a problem hiding this comment.
Why offline mode cannot be supported in DDP?
There was a problem hiding this comment.
Offline mode now supports DDP!
plyfager
approved these changes
Nov 8, 2021
LeoXing1996
added a commit
that referenced
this pull request
Jul 16, 2022
* support dist eval for IS and FID * support offline mode with DDP * update readme and script for slurm * fix bug in log print * fix bug in image saving * fix bug of log display in offline evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slurm_eval.shquick_run.md